Skip to content

REF: gradually move ExtensionIndex delegation to use inherit_names #30860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 28, 2020
Merged

REF: gradually move ExtensionIndex delegation to use inherit_names #30860

merged 13 commits into from
Jan 28, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jan 9, 2020 •
edited
Loading

Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-27 19:49:05 UTC

@jbrockmendel
Copy link
Member Author

Closing to clear the queue, will revisit once indexing fixes are done

@jbrockmendel jbrockmendel reopened this Jan 25, 2020
@jbrockmendel jbrockmendel mentioned this pull request Jan 27, 2020
Closed
@TomAugspurger
Copy link
Contributor

Are all of these changes appropriate for 1.0.0? Or does it rely on stuff that hasn't been backported?

@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 27, 2020
@jbrockmendel
Copy link
Member Author

Are all of these changes appropriate for 1.0.0? Or does it rely on stuff that hasn't been backported?

inherit_from_data was in the RC, though this does change that a little bit. I could do a PR that omits the CategoricalIndex and TimedeltaIndex edits.

@jreback jreback added Performance Memory or execution speed performance ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 28, 2020
@jreback jreback merged commit ddb3427 into pandas-dev:master Jan 28, 2020
@jreback
Copy link
Contributor

jreback commented Jan 28, 2020

thanks @jbrockmendel

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 28, 2020
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#30860: REF: gradually move ExtensionIndex dele…
91c4e95 
…gation to use inherit_names
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 28, 2020
Merged
jreback pushed a commit that referenced this pull request Jan 28, 2020
@meeseeksmachine @jbrockmendel @jreback
Backport PR #30860: REF: gradually move ExtensionIndex delegation to …
161f3f7 
…use inherit_names (#31375)

Co-authored-by: jbrockmendel <[email protected]>
@jbrockmendel jbrockmendel deleted the ref-delegate3 branch April 5, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Performance Memory or execution speed performance
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @pep8speaks @TomAugspurger @jreback